External References and Metadata Validations #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Alzate <[email protected]>
mr-zepol
force-pushed
the
Add_validations_external_references
branch
from
9a8c342 to
bd29da2
Compare
nscuro
approved these changes
Jun 15, 2024
Member
nscuro
left a comment
nscuro
left a comment
There was a problem hiding this comment.
and a smaller PR so it's easier to review
Much appreciated, that definitely helps!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds validation for serializer when creating SBOMs for external reference and metadata that values that are not present in the spec, this excludes them so the generated file is not invalid and it's compliant with the spec.
This is an improvement for the tests to test backward compatibility, and a smaller PR so it's easier to review